perf: optimize KeyMatch functions with fast path for wildcard replacement#1699
Open
AKonnyaku wants to merge 1 commit intoapache:masterfrom
Open
perf: optimize KeyMatch functions with fast path for wildcard replacement#1699AKonnyaku wants to merge 1 commit intoapache:masterfrom
AKonnyaku wants to merge 1 commit intoapache:masterfrom
Conversation
…ment
This change introduces a fast path optimization for KeyMatch2, KeyMatch3, KeyMatch4, KeyMatch5 and their corresponding KeyGet functions.
Original code (unconditional replacement):
key2 = strings.Replace(key2, "/*", "/.*", -1)
Optimized code (conditional replacement):
if strings.Contains(key2, "/*") { //nolint:gosimple // optimization
key2 = strings.Replace(key2, "/*", "/.*", -1)
}
This avoids unnecessary allocations and processing when the key does not contain a wildcard, as verified by upstream benchmarks using test data like 'examples/performance/rbac_with_pattern_large_scale_policy.csv'.
Benchmark ComparisonComparing base branch ( 🤖 This comment will be automatically updated with the latest benchmark results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request optimizes the performance of path matching functions in the utility package.